fix: contributors list screen reader announcement #2889
Conversation
Codecov ReportBase: 66.02% // Head: 67.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
+ Coverage 66.02% 67.18% +1.15%
==========================================
Files 118 130 +12
Lines 1351 1484 +133
Branches 342 364 +22
==========================================
+ Hits 892 997 +105
- Misses 422 447 +25
- Partials 37 40 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I've updated it to use the useIntl hook and checked that it still works with a screen reader (NVDA on windows). If there's any names (or anything else) that you want me to change let me know, I'm not well versed enough in the project to know if you have any naming conventions you follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two tiny comments, but regardless, super work! I hope you didn't face many issues in achieving the final result.
Feedback is welcome if you feel any guidelines were missing or if anything could be improved. Thank you, again, for your contribution 💖
Thanks, I’ll fix it tomorrow 👍🏻 I did try without definedMessages but got myself in a mess with curly braces. Hopefully I can work it out once I’ve slept (and I now have your example above 😊 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
The contributors list on the about page was announcing every person twice when read with a screen reader because link had a title and the image had an alt text. I removed the image alt text and left an empty string so the name is not read out twice. I also replaced title with an aria-label which has better support overall with different assistive technologies. The title attribute is not well supported unfortunately. Also added 'opens in new tab' to the label so that any blind users do not get disorientated by the change of context.
Updated snapshots
Related Issues
Check List
npm run lint:js -- --fix
and/ornpm run lint:md -- --fix
for my JavaScript and/or Markdown changes.npm run test
to check if all tests are passing, and/ornpm run test -- -u
to update snapshots if I created and/or updated React Components.npm run build
work fine.