Fix: download toggle button accessibility/translation support #2928
Conversation
Codecov ReportBase: 66.02% // Head: 67.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
+ Coverage 66.02% 67.08% +1.05%
==========================================
Files 118 136 +18
Lines 1351 1531 +180
Branches 342 357 +15
==========================================
+ Hits 892 1027 +135
- Misses 422 462 +40
- Partials 37 42 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 🌈
I've updated this according to the comments. Let me know if there's anything else needs doing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
The second toggle button on the download page didn't have correct aria-checked or aria-label values due to a copy-paste mistake I am guessing. They are now updated to match the corresponding button.
While I was there I added them to the translation files ready to be translated.
Related Issues
Check List
npm run lint:js -- --fix
and/ornpm run lint:md -- --fix
for my JavaScript and/or Markdown changes.npm run test
to check if all tests are passing, and/ornpm run test -- -u
to update snapshots if I created and/or updated React Components.npm run build
work fine.