Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Add minutes from 2015-04-16 meeting #107

Closed
wants to merge 1 commit into from
Closed

Add minutes from 2015-04-16 meeting #107

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 24, 2015

Minutes..

@srl295
Copy link
Member Author

srl295 commented Apr 24, 2015

@joyent/node-coreteam FYI

@mhdawson
Copy link
Member

The github link for me should be https://github.com/mhdawson

misterdjules
misterdjules reviewed Apr 27, 2015
View reviewed changes
doc/about/core-team/meetings/2015-04-16/minutes.md

MD: this is a tempoary fix, most people (hopefully) are using defaults.

TJ: this is more in minor versions, when peopel are bringing up the app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peopel -> people. Although I'm not sure what the whole sentence refers to.

@srl295
Copy link
Member Author

srl295 commented Apr 27, 2015

Review notes incorporated

@srl295 srl295 closed this Apr 27, 2015
@srl295 srl295 reopened this Apr 27, 2015
misterdjules
misterdjules reviewed Apr 27, 2015
View reviewed changes
doc/about/core-team/meetings/2015-04-16/minutes.md

TJ: this should be first class documentation.

- [ ] srl, open a new ticket. Document that Date.now != how timers work.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could replace [ ] with: Action item:...?

@srl295 srl295 self-assigned this Apr 28, 2015
misterdjules
misterdjules reviewed Apr 28, 2015
View reviewed changes
doc/about/core-team/meetings/2015-04-16/minutes.md

#### Wrong checksum for node v0.12.2

* This issue will be investigated. (by whom?)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for bullet point, issue was investigated by me.

@misterdjules
Copy link

@srl295 Thank you! Please squash all the commits in one commit that has "Add minutes from 2015-04-16 meeting" as a commit message. Once that is done, LGTM!

@srl295
Copy link
Member Author

srl295 commented Apr 28, 2015

@misterdjules thank you!

@misterdjules
Copy link

LGTM, thank you @srl295.

srl295 added a commit that referenced this pull request Apr 28, 2015
@srl295
Add minutes from 2015-04-16 meeting
90ad03c 
PR: #107
PR-URL: #107
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
@misterdjules
Copy link

Landed in 90ad03c, thanks again!

@misterdjules
Copy link

Deployed at https://nodejs.org/about/core-team/meetings/2015-04-16/minutes.html.

@srl295 srl295 deleted the 2015-04-16b branch April 30, 2015 15:59
@srl295 srl295 removed their assignment Jun 22, 2015
@phillipj phillipj mentioned this pull request Mar 22, 2016
Closed
@williamkapke williamkapke mentioned this pull request Mar 22, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srl295 @mhdawson @misterdjules