Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Add minutes for meeting of 04/24/2015 #108

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Add minutes for meeting of 04/24/2015 #108

merged 1 commit into from
Apr 27, 2015

Conversation

mhdawson
Copy link
Member

Add minutes for meeting of 04/24/2015

@geek geek self-assigned this Apr 27, 2015

In advance, we should start looking to see if we can make the inclusion of ICU more
modular in a non breaking way. Action: Michael to setup meeting with Steven/James
to better understand depencies between startup and V8 with respect to ICU.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: dependencies

@mhdawson
Copy link
Member Author

3 comments so far addressed.

geek added a commit that referenced this pull request Apr 27, 2015
Add minutes for meeting of 04/24/2015
@geek geek merged commit d23b6ab into nodejs:master Apr 27, 2015
@misterdjules
Copy link

@mhdawson Thank you!

doc/about/core-team/meetings/index.md needs to be updated with a new entry for these minutes (including a link to it). You can test that the website is generated properly by running make test.

@mhdawson
Copy link
Member Author

I seem to get an error when running make tests. IT complains about

hecking for doc/nodejs-advisory-board/governance-proposal/TSC-Project-Lifecycle.json
using template doc/website.html
/home/mhdawson/node-website-pull/node-website/tools/doc/generate.js:118
if (er) throw er;
^
Error: Inappropriate heading level
{"type":"heading","depth":2,"text":"_DRAFT for Public Comment_"}
at /home/mhdawson/node-website-pull/node-website/tools/doc/html.js:163:17
at Array.forEach (native)
at buildToc (/home/mhdawson/node-website-pull/node-website/tools/doc/html.js:160:9)
at render (/home/mhdawson/node-website-pull/node-website/tools/doc/html.js:48:3)
at /home/mhdawson/node-website-pull/node-website/tools/doc/html.js:34:5
at fs.js:334:14
at FSReqWrap.oncomplete (fs.js:95:15)
make: *** [out/doc/nodejs-advisory-board/governance-proposal/TSC-Project-Lifecycle.html] Error 1

@mhdawson
Copy link
Member Author

PR to update index #109

@mhdawson
Copy link
Member Author

PR to fix markdown errors in advisory board files:
joyent/nodejs-advisory-board#40

@mhdawson
Copy link
Member Author

I now get as far as:

open http://localhost:8080
Couldn't get a file descriptor referring to the console
make: *** [test] Error 1

I assume that's because I would have to setup a web server ?

@misterdjules
Copy link

@mhdawson The web server is started after open is started. It works on OSX, but I haven't tested it on other platforms, so there may be a bug here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants