Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Add minutes for 04-30-2015 meeting #110

Merged
merged 1 commit into from
May 1, 2015

Conversation

misterdjules
Copy link

/cc @joyent/node-coreteam @geek @robertkowalski.

@geek geek self-assigned this May 1, 2015
geek added a commit that referenced this pull request May 1, 2015
@geek geek merged commit 08b1d02 into nodejs:master May 1, 2015
@misterdjules
Copy link
Author

@geek Thank you!

Just out of curiosity, is there a reason why it was merged with the git merge button rather than with git-apply-pr? If using git-apply-pr is too annoying, we can maybe make it easier to use, as I would like to avoid having a lot of unnecessary merge commits.

Thoughts?

@geek
Copy link
Member

geek commented May 1, 2015

For the website there isn't a lot of advantage. The green button works well for this repo. @robertkowalski agrees, right?

@Fishrock123
Copy link
Member

as I would like to avoid having a lot of unnecessary merge commits.

While I also prefer this, we at the io.js website also settled on just using the green button.

@robertkowalski
Copy link
Contributor

I am a fan of git-apply-pr but I also don't mind if Wyatt wants to use the
green button for the website.

On Fri, May 1, 2015 at 8:49 PM, Jeremiah Senkpiel notifications@github.com
wrote:

as I would like to avoid having a lot of unnecessary merge commits.

While I also prefer this, the io.js website also settled on just using the
green button.


Reply to this email directly or view it on GitHub
#110 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants