Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Add foundation section #115

Closed
wants to merge 1 commit into from
Closed

Add foundation section #115

wants to merge 1 commit into from

Conversation

misterdjules
Copy link

Superseding #113. This PR builds on top of #113 and integrate the new "Foundation" section into the existing website.

@misterbisson @joyent/node-coreteam @robertkowalski @geek Feedback welcome!

@misterdjules misterdjules mentioned this pull request May 14, 2015
Closed
@misterdjules
Copy link
Author

@misterbisson If you want to see how it looks, just run make test. Let me know if you have any question.

@misterbisson
Copy link
Contributor

:shipit:

@misterdjules misterdjules mentioned this pull request May 14, 2015
Closed
misterbisson
misterbisson reviewed May 15, 2015
View reviewed changes
doc/foundation/members.md

## Scott Hammond, Joyent

I am the CEO of Joyent and full background can be found here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I am the CEO of Joyent and my full background can be on joyent.com."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that will be fixed soon.

robertkowalski
robertkowalski reviewed May 15, 2015
View reviewed changes
doc/foundation.html
<ul class="docs-nav">
<li><a href="/foundation/">Node.js Foundation</a></li>
<li>&nbsp;&nbsp;&nbsp; - <a href="#index_md_timeline">Timeline</a></li>
<li>&nbsp;&nbsp;&nbsp; - <a href="#index_md_core_documents">Core Documents</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go to "members" - the click on Timeline or Core Documents - the url must include /foundation/ as prefix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if they also get highlighted then, but they probably should get highlighted (or the main point foundation)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Fixed and yes, the main "table of content" item (Node.js Foundation) is highlighted in that case.

@robertkowalski
Copy link
Contributor

one smaller issue other than that LGTM

misterdjules pushed a commit that referenced this pull request May 15, 2015
Add Node.js Foundation section/page
40d35ea 
PR: #115
PR-URL: #115
Reviewed-By: Robert Kowalski <rok@kowalski.gd>
@misterdjules
Copy link
Author

Landed in 40d35ea and subsequent fixups 65aed7e and 9522ec5.

Deployed at https://nodejs.org/foundation/.
Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misterdjules @misterbisson @robertkowalski