blog: make blog mobile friendly #117
Conversation
Currently the blog is not mobile optimized, making for tough viewing from mobile devices. This commit makes it mobile friendly. CSS added is scoped to the blog only.
|
/cc @joyent/node-website Is someone available to review these changes? I'm not a CSS expert, far from it, so I'd rather have someone more experienced than me in this area to do it :) |
|
I haven't actually tested it, but the changes look fine. [by which I mean I am a CSS expert, and this looks like it will behave as described] |
|
If there's anything more I can do on this let me know, thanks for looking into it @misterdjules @fitzage |
|
@johnbrett We would need someone to test it and report the test results. I find it's generally good practice to have someone who didn't write the code to test changes, as they have not any bias and find more ways to break it. |
|
@joyent/node-website Is anyone available to test these changes? |
|
I reviewed the changes and made two minor adjustments. |
|
@fhemberger no thanks needed! glad I'll be able to read the blog on my phone now - thanks for reviewing and merging! |
|
Hi @fhemberger, did this make it to the node website yet? Not seeing any change viewing the blog on mobile as of yet! |
|
Unfortunately not, I can merge PRs but I cannot update the website yet. Waiting for @misterdjules or @robertkowalski … |
|
@johnbrett The changes in this PR have been deployed at around 4am PDT, could you please check back and let us know if you see them live at nodejs.org? |
|
@misterdjules @johnbrett I just checked: LGTM! |
|
@fhemberger Thank you! |
|
Thanks @misterdjules @fhemberger! Looks good! |
blog: make blog mobile friendly
Currently the blog is not mobile optimized, making
for tough viewing from mobile devices. This commit
makes it mobile friendly. CSS added is scoped to the
blog only, other pages will not appear any differently.