Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of both URLSearchParams.toString and querystring.stringify #56

Open
anonrig opened this issue Feb 13, 2023 · 3 comments
Open

Improve the performance of both URLSearchParams.toString and querystring.stringify #56

anonrig opened this issue Feb 13, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@anonrig
Copy link
Member

anonrig commented Feb 13, 2023

Fast-querystring is almost 2x faster for stringifying. Let's copy my code (which is MIT) to Node.js

https://github.com/anonrig/fast-querystring
@anonrig anonrig added the good first issue Good for newcomers label Feb 13, 2023
@debadree25
Copy link
Member

Is it to be introduced as new dependency?

@anonrig
Copy link
Member Author

anonrig commented Feb 13, 2023

We can just copy paste certain parts to the Node repository.

@debadree25
Copy link
Member

understood
will attempt this!

debadree25 added a commit to debadree25/node that referenced this issue Feb 23, 2023
@debadree25
url: improve URLSearchParams.toString() performance
d4f66af 
Refs: nodejs/performance#56
debadree25 added a commit to debadree25/node that referenced this issue Feb 23, 2023
@debadree25
url: improve URLSearchParams.toString() performance
3715f52 
Refs: nodejs/performance#56
debadree25 added a commit to debadree25/node that referenced this issue Feb 24, 2023
@debadree25
benchmark: add a benchmark for URLSearchParams.toString()
e717c91 
Refs: nodejs/performance#56
@debadree25 debadree25 mentioned this issue Feb 24, 2023
Merged
debadree25 added a commit to debadree25/node that referenced this issue Feb 24, 2023
@debadree25
benchmark: add a benchmark for URLSearchParams creation and toString()
b2bd057 
Refs: nodejs/performance#56
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Mar 13, 2023
@debadree25
benchmark: add a benchmark for URLSearchParams creation and toString()
28c9fb9 
Refs: nodejs/performance#56
PR-URL: #46810
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Mar 13, 2023
@debadree25 @targos
benchmark: add a benchmark for URLSearchParams creation and toString()
cf80847 
Refs: nodejs/performance#56
PR-URL: #46810
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Mar 14, 2023
@debadree25 @targos
benchmark: add a benchmark for URLSearchParams creation and toString()
7cfd31a 
Refs: nodejs/performance#56
PR-URL: #46810
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 11, 2023
@debadree25 @danielleadams
benchmark: add a benchmark for URLSearchParams creation and toString()
b5db3b5 
Refs: nodejs/performance#56
PR-URL: #46810
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anonrig @debadree25