Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns.lookup performance #77

Closed
anonrig opened this issue May 8, 2023 · 0 comments · Fixed by nodejs/node#47920
Closed

dns.lookup performance #77

anonrig opened this issue May 8, 2023 · 0 comments · Fixed by nodejs/node#47920

Comments

@anonrig
Copy link
Member

anonrig commented May 8, 2023

dns.lookup performance can be improved by a significant margin, if we called toASCII method in C++ side, instead of in Javascript. This would reduce C++/JS bridge crossing.
@anonrig anonrig mentioned this issue May 8, 2023
Merged
targos pushed a commit to nodejs/node that referenced this issue May 12, 2023
@anonrig @targos
dns: call ada::idna::to_ascii directly from c++
9be9228 
PR-URL: #47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 10, 2023
@anonrig @targos
dns: call ada::idna::to_ascii directly from c++
284a869 
PR-URL: #47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
dns: call ada::idna::to_ascii directly from c++
162081d 
PR-URL: nodejs/node#47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
dns: call ada::idna::to_ascii directly from c++
3e323da 
PR-URL: nodejs/node#47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dns: call ada::idna::to_ascii directly from c++ nodejs/node
1 participant
@anonrig