Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce URL initializations in ESM #92

Closed
anonrig opened this issue Jun 1, 2023 · 1 comment
Closed

Reduce URL initializations in ESM #92

anonrig opened this issue Jun 1, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@anonrig
Copy link
Member

anonrig commented Jun 1, 2023

There is still some work need to remove the unnecessary URL initialization in the ESM loader.

Ref: nodejs/node#48272
@anonrig anonrig mentioned this issue Jun 5, 2023
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Jun 7, 2023
@anonrig
module: reduce url invocations in esm/load.js
9d936fa 
PR-URL: #48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@anonrig anonrig mentioned this issue Jun 18, 2023
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Jun 24, 2023
@anonrig
lib: reduce url getters on makeRequireFunction
578ffe1 
PR-URL: #48492
Refs: nodejs/performance#92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Jul 3, 2023
@anonrig @RafaelGSS
module: reduce url invocations in esm/load.js
4ec2d92 
PR-URL: #48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Jul 3, 2023
@anonrig @RafaelGSS
lib: reduce url getters on makeRequireFunction
32bda81 
PR-URL: #48492
Refs: nodejs/performance#92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson mhdawson mentioned this issue Jul 5, 2023
Closed
@anonrig anonrig added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 10, 2023
@mhdawson mhdawson mentioned this issue Jul 19, 2023
Closed
@mhdawson mhdawson mentioned this issue Aug 2, 2023
Closed
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@anonrig @Ceres6
module: reduce url invocations in esm/load.js
cb3c3af 
PR-URL: nodejs#48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@anonrig @Ceres6
lib: reduce url getters on makeRequireFunction
5c6445d 
PR-URL: nodejs#48492
Refs: nodejs/performance#92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@anonrig @Ceres6
module: reduce url invocations in esm/load.js
7673e40 
PR-URL: nodejs#48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@anonrig @Ceres6
lib: reduce url getters on makeRequireFunction
cbb7682 
PR-URL: nodejs#48492
Refs: nodejs/performance#92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson mhdawson mentioned this issue Aug 16, 2023
Closed
ruyadorno pushed a commit to nodejs/node that referenced this issue Aug 29, 2023
@anonrig @ruyadorno
module: reduce url invocations in esm/load.js
bf1525c 
PR-URL: #48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@mhdawson mhdawson mentioned this issue Aug 30, 2023
Closed
@anonrig
Copy link
Member Author

anonrig commented Sep 6, 2023

There has been couple of works done on this issue. Closing it for now.

@anonrig anonrig closed this as completed Sep 6, 2023
ruyadorno pushed a commit to nodejs/node that referenced this issue Sep 10, 2023
@anonrig @ruyadorno
lib: reduce url getters on makeRequireFunction
edab50c 
PR-URL: #48492
Refs: nodejs/performance#92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit to nodejs/node that referenced this issue Sep 13, 2023
@anonrig @ruyadorno
lib: reduce url getters on makeRequireFunction
5d682c5 
PR-URL: #48492
Refs: nodejs/performance#92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anonrig