fix: compilation error on macOS >= 13 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
requested review from
dsanders11,
jviotti and
robertgzr
as code owners
RaisinTen
force-pushed
the
fix-compilation-error-on-macOS-13
branch
2 times, most recently
from
203dd9f
to
4a93061
Compare
Fixes: #68 Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
fix-compilation-error-on-macOS-13
branch
from
4a93061
to
044c656
Compare
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Dec 22, 2022
* nodejs/postject@b9356bf * nodejs/postject@2f858f7 * nodejs/postject#69 Signed-off-by: Darshan Sen <raisinten@gmail.com>
tony-go
approved these changes
Dec 23, 2022
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Jan 3, 2023
* nodejs/postject@b9356bf * nodejs/postject@2f858f7 * nodejs/postject#69 Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
I have tested this change in nodejs/node#45038 and it compiles on all platforms, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #68
Signed-off-by: Darshan Sen raisinten@gmail.com