feat: add base logger #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-go
requested review from
RaisinTen,
dsanders11,
jviotti and
robertgzr
as code owners
RaisinTen
reviewed
Feb 22, 2023
tony-go
commented
Feb 24, 2023
RaisinTen
reviewed
Feb 26, 2023
There was a problem hiding this comment.
The next step would be to add a patch file to patches/lief for the changes that have been made to vendor/lief. You can run git format-patch -1 --zero-commit --relative in the vendor/lief directory to generate the patch file and move it to the location and commit it.
robertgzr
approved these changes
Feb 28, 2023
robertgzr
approved these changes
Mar 2, 2023
RaisinTen
added a commit
that referenced
this pull request
Mar 3, 2023
Originated in #73. Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added a commit
that referenced
this pull request
Mar 3, 2023
Originated in #73. Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added a commit
that referenced
this pull request
Mar 3, 2023
#73 uncommented an assertion which is known to fail on linux, so comment it once again. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Merged
RaisinTen
added a commit
that referenced
this pull request
Mar 3, 2023
#73 uncommented an assertion which is known to fail on linux, so comment it once again. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #71