Evade override mistake (#474)

nodejs · Jun 11, 2022 · 431a9af · 431a9af
1 parent 81c5264
commit 431a9af
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/src/errors.js b/src/errors.js
@@ -86,12 +86,22 @@ function E(code, message, Base) {
     }
   }
 
-  NodeError.prototype.name = Base.name
+  Object.defineProperties(NodeError.prototype, {
+    name: {
+      value: Base.name,
+      writable: true,
+      enumerable: false,
+      configurable: true,
+    },
+    toString: {
+      value() { return `${this.name} [${code}]: ${this.message}`; },
+      writable: true,
+      enumerable: false,
+      configurable: true,
+    }    
+  });
   NodeError.prototype.code = code
   NodeError.prototype[kIsNodeError] = true
-  NodeError.prototype.toString = function () {
-    return `${this.name} [${code}]: ${this.message}`
-  }
 
   codes[code] = NodeError
 }