Add build regexp IE11 (isInteger) (#389)

nodejs · Dec 13, 2018 · a2009a9 · a2009a9
1 parent 09a71b1
commit a2009a9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/build/build.js b/build/build.js
diff --git a/build/files.js b/build/files.js
@@ -193,9 +193,13 @@ function CorkedRequest(state) {
         'const { emitExperimentalWarning } = require(\'../experimentalWarning\');'
   ]
   , numberIE11 = [
-          /Number.isNaN\(n\)/g
+          /Number\.isNaN\(n\)/g
       ,   'n !== n'
   ]
+  , integerIE11 = [
+          /Number\.isInteger\(hwm\)/g
+    ,     '(isFinite(hwm) && Math.floor(hwm) === hwm)'
+  ]
   , noAsyncIterators1 = [
           /Readable\.prototype\[Symbol\.asyncIterator\] = function\(\) \{/g
       ,   'if (typeof Symbol === \'function\' ) {\nReadable.prototype[Symbol.asyncIterator] = function () {'
@@ -313,6 +317,7 @@ module.exports['internal/streams/destroy.js'] = [
 
 module.exports['internal/streams/state.js'] = [
   , errorsTwoLevel
+  , integerIE11
 ]
 
 module.exports['internal/streams/async_iterator.js'] = [

diff --git a/lib/internal/streams/state.js b/lib/internal/streams/state.js
@@ -9,7 +9,7 @@ function highWaterMarkFrom(options, isDuplex, duplexKey) {
 function getHighWaterMark(state, options, duplexKey, isDuplex) {
   var hwm = highWaterMarkFrom(options, isDuplex, duplexKey);
   if (hwm != null) {
-    if (!Number.isInteger(hwm) || hwm < 0) {
+    if (!(isFinite(hwm) && Math.floor(hwm) === hwm) || hwm < 0) {
       var name = isDuplex ? duplexKey : 'highWaterMark';
       throw new ERR_INVALID_OPT_VALUE(name, hwm);
     }