Simpler event stream sub

[calvinmetcalf]

fix for #277, hopfully

[mcollina]

LGTM and let's see what happens.

[calvinmetcalf]

wait actually I have a better idea

[calvinmetcalf]

we already are successfully using the package.browser switch, so lets use it for this

[calvinmetcalf]

ok @mcollina check this out

[RangerMauve]

@calvinmetcalf You'll want to apply these changes to the react-native field, too, or get rid of it to use the browser version instead.

[calvinmetcalf]

ok good call

[RangerMauve]

Err, wait, it'll still break on loading the stream module. Maybe copy the whole browser object, and for React-Native add "stream": false. Since it needs all the changes for browser compatibility, plus it needs the stream module to be explicitly excluded, else the require("st" + "ream") call will crash the bundler.

[calvinmetcalf]

there shouldn't be any stream calls anymore in the browser code

[RangerMauve]

You're right, sorry about that. :P

[calvinmetcalf]

so it's good ?

[mcollina]

you can pull https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js from core. That's what there is in stream.

[calvinmetcalf]

@mcollina the idea isn't that we need the same api, it's that instanceof stream checks should succeed

[mcollina]

LGTM