Forward-port of nodejs#13850 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmetcalf
approved these changes
Jun 22, 2017
|
nice but we have to be carefull because any other pull will likely revert it |
calvinmetcalf
suggested changes
Jun 22, 2017
lib/_stream_writable.js
Outdated
| process.nextTick(cb, er); | ||
| // this can emit finish, and it will always happen | ||
| // after error | ||
| process.nextTick(finishMaybe, stream, state); |
There was a problem hiding this comment.
this needs to be processNextTick
lib/_stream_writable.js
Outdated
| if (sync) { | ||
| // defer the callback if we are being called synchronously | ||
| // to avoid piling up things on the stack | ||
| process.nextTick(cb, er); |
There was a problem hiding this comment.
needs to be processNextTick
|
lgtm, other than the other comments, with the caveats that i'm 100% up to date with the new mechanics. Are there any guarantees now about close firing before after finish etc? |
I have no idea. I think the two things are loosely correlated in duplexes. Given the rate of unexpected breakage, I think we have poor coverage of the state machine and the ecosystem. |
calvinmetcalf
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, here is the forward-port of that PR. It will likely be part of Node 8.1.3, which will likely be released next week. I'm not sure if it's worth porting it forward here.
nodejs/node#13850
cc @phated