✨ Add command for release signers to easily import keys #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset introduces an "add" command that can be used by the Node.js release signing team to add or update their own release signing keys. ``` $ ./cli.sh add <signing-key-id> ``` For example: `./cli.sh add 4ED778F539E3634C779C87C6D7062848A1AB005C` After this command has been added, members of the release signing team can create PRs to update their own keys as follows: 1. Clone the latest default branch (e.g: `master`) and create a feature branch. 2. For each release signing key you have used or intend to use: run `./cli.sh add <key-id>` with the full key ID. 3. Manually update README.md, as needed. 4. Commit the result, push to the feature branch, and create a PR to have that merged into the default branch.
This was referenced Jun 30, 2021
targos
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
I don't know much about shell syntax, but behavior with my key seems good:
$ ./cli.sh add 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
gpg: WARNING: unsafe permissions on homedir '/Users/targos/git/nodejs/release-keys/gpg'
gpg: key 770F7A9A5AE15600: "Michaël Zasso (Targos) <targos@protonmail.com>" not changed
gpg: Total number processed: 1
gpg: unchanged: 1
keys.list <- 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #6.
This changeset introduces an "add" command that can be used by
the Node.js release signing team to add or update their own
release signing keys.
For example:
./cli.sh add 4ED778F539E3634C779C87C6D7062848A1AB005CAfter this command has been added, members of the release signing
team can create PRs to update their own keys as follows:
master) and create a feature branch../cli.sh add <key-id>with the full key ID.