Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-dependency-vuln-assessments automation failing #1181

Closed
RafaelGSS opened this issue Jan 4, 2024 · 3 comments · Fixed by nodejs/nodejs-dependency-vuln-assessments#171
Closed

nodejs-dependency-vuln-assessments automation failing #1181

RafaelGSS opened this issue Jan 4, 2024 · 3 comments · Fixed by nodejs/nodejs-dependency-vuln-assessments#171

Comments

@RafaelGSS
Copy link
Member

https://github.com/nodejs/nodejs-dependency-vuln-assessments/actions/runs/7403801684/job/20144512435
@richardlau
Copy link
Member

richardlau commented Jan 4, 2024 •
edited

It is failing to parse the version of brotli after nodejs/node#50804
BROTLI_VERSION is now defined as

#define BROTLI_VERSION BROTLI_MAKE_HEX_VERSION(                     \
  BROTLI_VERSION_MAJOR, BROTLI_VERSION_MINOR, BROTLI_VERSION_PATCH)

instead of as a hex string. (note that BROTLI_VERSION_MAJOR, BROTLI_VERSION_MINOR, and BROTLI_VERSION_PATCH do not exist in earlier versions of brotli.)

@richardlau richardlau mentioned this issue Jan 4, 2024
Merged
@richardlau
Copy link
Member

PR: nodejs/nodejs-dependency-vuln-assessments#171

@richardlau richardlau mentioned this issue Jan 4, 2024
Merged
@richardlau
Copy link
Member

The update script for brotli also needs to be fixed for the same reason.
PR: nodejs/node#51373

nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Jan 7, 2024
@richardlau
tools: fix version parsing in brotli update script
15b38fa 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this issue Jan 12, 2024
@richardlau @marco-ippolito
tools: fix version parsing in brotli update script
c63f465 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this issue Jan 19, 2024
@richardlau @Medhansh404
tools: fix version parsing in brotli update script
54cda22 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to nodejs/node that referenced this issue Feb 15, 2024
@richardlau @targos
tools: fix version parsing in brotli update script
29492e2 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau added a commit to nodejs/node that referenced this issue Mar 25, 2024
@richardlau
tools: fix version parsing in brotli update script
d460750 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau added a commit to nodejs/node that referenced this issue Mar 25, 2024
@richardlau
tools: fix version parsing in brotli update script
4ce2ecb 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this issue Jun 1, 2024
@richardlau @lukins-cz
tools: fix version parsing in brotli update script
d46a018 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix parsing for newer versions of brotli nodejs/nodejs-dependency-vuln-assessments
2 participants
@richardlau @RafaelGSS