Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CII-Best-Practices for Nodejs: Entry level #954

Merged
merged 10 commits into from
Jun 8, 2023

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Apr 16, 2023

Related #953

This pull request contains a dump of the current questions and answers for the Node.js project in OpenSSF Best Practices for Entry Level. The purpose is to review the current answers, update and comment on them until we have a final version, and then update the OpenSSF Best Practices site.

@UlisesGascon UlisesGascon marked this pull request as ready for review April 16, 2023 16:15
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marco-ippolito I'm not sure, but isn't cpe:2.3:a:nodejs:node.js:*:*:*:*:-:*:*:* the CPE?

tools/ossf_best_practices/passing_criteria.md Outdated Show resolved Hide resolved
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
@UlisesGascon UlisesGascon self-assigned this May 23, 2023
@marco-ippolito
Copy link
Member

I think this is ready, might want to discuss it in #1012

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS merged commit a55ed1d into nodejs:main Jun 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants