Skip to content
This repository has been archived by the owner on May 13, 2019. It is now read-only.

Check in resources/scripts for coverage generation #38

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Add patch files that enable coverage generation for Node core
as well as a simple script for rendering a table of nightly
coverage results.

Ref: #36

The files are taken as they are in https://github.com/addaleax/node-core-coverage

/cc @mhdawson

Add patch files that enable coverage generation for Node core
as well as a simple script for rendering a table of nightly
coverage results.

Ref: nodejs#36
@mhdawson
Copy link
Member

LGTM

@mhdawson
Copy link
Member

I'm not actually a member of the testing team so not sure if I should/can land. @nodejs/testing for more review/comments.

@Trott
Copy link
Member

Trott commented Oct 13, 2016

Is this the right repo for these files? This repo generally doesn't have any code, just documentation and guides and whatnot. Fine with it if it's the best place. But just curious if the actual coverage code is living somewhere else and it should go there?

@addaleax
Copy link
Member Author

But just curious if the actual coverage code is living somewhere else and it should go there?

I think it’s going to end up in the Jenkins config in some way, if I’ve understood @mhdawson correctly?

@Trott
Copy link
Member

Trott commented Oct 13, 2016

Would https://github.com/nodejs/build be the right place for it then? /cc @mhdawson @jbergstroem

@mhdawson
Copy link
Member

These files will be used by the job in jenkins. I was thinking they'd go in the testing repo as something associated/owned by the testing group. It is also the same approach we took for the files supporting the nightly benchmarking jobs. Having said that if others think it should be in the build repo instead I'm fine with that as well. @jbergstroem what's your take ?

@mhdawson mhdawson self-assigned this Oct 20, 2016
@mhdawson
Copy link
Member

I talked with @jbergstroem through IRC and he seemed ok with them going here. Unless I hear additional objections I'll go ahead and land in the next day or so.

mhdawson pushed a commit that referenced this pull request Nov 1, 2016
Add patch files that enable coverage generation for Node core
as well as a simple script for rendering a table of nightly
coverage results.

Ref: #36

PR-URL: #38
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

mhdawson commented Nov 1, 2016

landed as d41c55d

@mhdawson mhdawson closed this Nov 1, 2016
maclover7 pushed a commit to maclover7/build that referenced this pull request Dec 31, 2017
Add patch files that enable coverage generation for Node core
as well as a simple script for rendering a table of nightly
coverage results.

Ref: nodejs/testing#36

PR-URL: nodejs/testing#38
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants