test(wpt): handle uncaught exceptions (#1965)

nodejs · Feb 23, 2023 · 0faf03e · 0faf03e
1 parent 178a97c
commit 0faf03e
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/test/wpt/runner/runner/runner.mjs b/test/wpt/runner/runner/runner.mjs
@@ -31,6 +31,8 @@ export class WPTRunner extends EventEmitter {
   /** Tests that have expectedly failed mapped by file name */
   #statusOutput = {}
 
+  #uncaughtExceptions = []
+
   #stats = {
     completed: 0,
     failed: 0,
@@ -58,6 +60,13 @@ export class WPTRunner extends EventEmitter {
         this.emit('completion')
       })
     }
+
+    this.once('completion', () => {
+      for (const exception of this.#uncaughtExceptions) {
+        console.log(colors(`Uncaught exception: ${exception.stack}`, 'red'))
+        console.log('='.repeat(96))
+      }
+    })
   }
 
   static walk (dir, fn) {
@@ -148,6 +157,10 @@ export class WPTRunner extends EventEmitter {
             this.handleIndividualTestCompletion(message, status, test)
           } else if (message.type === 'completion') {
             this.handleTestCompletion(worker)
+          } else if (message.type === 'error') {
+            this.#uncaughtExceptions.push(message.error)
+            this.#stats.failed += 1
+            this.#stats.success -= 1
           }
         })
 
@@ -196,7 +209,7 @@ export class WPTRunner extends EventEmitter {
           if (!file.allowUnexpectedFailures && !topLevel.allowUnexpectedFailures) {
             if (Array.isArray(file.fail)) {
               this.#statusOutput[path] ??= []
-              this.#statusOutput[path].push(file.fail)
+              this.#statusOutput[path].push(name)
             }
           }
 

diff --git a/test/wpt/runner/runner/worker.mjs b/test/wpt/runner/runner/worker.mjs
@@ -18,6 +18,17 @@ import { CloseEvent } from '../../../../lib/websocket/events.js'
 
 const { initScripts, meta, test, url, path } = workerData
 
+process.on('uncaughtException', (err) => {
+  parentPort.postMessage({
+    type: 'error',
+    error: {
+      message: err.message,
+      name: err.name,
+      stack: err.stack
+    }
+  })
+})
+
 const basePath = join(process.cwd(), 'test/wpt/tests')
 const urlPath = path.slice(basePath.length)
 

diff --git a/test/wpt/tests/fetch/api/abort/general.any.js b/test/wpt/tests/fetch/api/abort/general.any.js
@@ -519,6 +519,7 @@ promise_test(async t => {
   const fetchPromise = fetch('../resources/empty.txt', {
     body, signal,
     method: 'POST',
+    duplex: 'half',
     headers: {
       'Content-Type': 'text/plain'
     }