fix: call explicitly unregister

nodejs · Dec 21, 2023 · 6565e6d · 6565e6d
1 parent c5c6648
commit 6565e6d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/compat/dispatcher-weakref.js b/lib/compat/dispatcher-weakref.js
@@ -28,6 +28,8 @@ class CompatFinalizer {
       })
     }
   }
+
+  unregister (key) {}
 }
 
 module.exports = function () {

diff --git a/lib/fetch/request.js b/lib/fetch/request.js
@@ -34,7 +34,12 @@ const { getMaxListeners, setMaxListeners, getEventListeners, defaultMaxListeners
 
 const kAbortController = Symbol('abortController')
 
-const requestFinalizer = new FinalizationRegistry(({ signal, abort }) => {
+const requestFinalizer = new FinalizationRegistry(({ signal, abort, controller }) => {
+  // Currently FinalizationRegistry has a problem and will explicitly unregister.
+  // https://github.com/nodejs/node/issues/49344
+  // https://github.com/nodejs/node/issues/47748
+  // It will be removed in the future.
+  requestFinalizer.unregister(controller)
   signal.removeEventListener('abort', abort)
 })
 
@@ -388,7 +393,7 @@ class Request {
         } catch {}
 
         util.addAbortListener(signal, abort)
-        requestFinalizer.register(ac, { signal, abort })
+        requestFinalizer.register(ac, { signal, abort, controller: ac })
       }
     }