Skip to content

Commit

Permalink
Revert "fix casing issue when cloning Headers object (#3160)"
Browse files Browse the repository at this point in the history
This reverts commit 034e3f0.
  • Loading branch information
tsctx committed Apr 24, 2024
1 parent 034e3f0 commit 8f2c2f5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 39 deletions.
6 changes: 0 additions & 6 deletions lib/web/fetch/headers.js
Original file line number Diff line number Diff line change
Expand Up @@ -602,12 +602,6 @@ webidl.converters.HeadersInit = function (V) {
if (webidl.util.Type(V) === 'Object') {
const iterator = Reflect.get(V, Symbol.iterator)

// A work-around to ensure we send the properly-cased Headers when V is a Headers object.
// Read https://github.com/nodejs/undici/pull/3159#issuecomment-2075537226 before touching, please.
if (!util.types.isProxy(V) && kHeadersList in V && iterator === Headers.prototype.entries) { // Headers object
return V[kHeadersList].entries
}

if (typeof iterator === 'function') {
return webidl.converters['sequence<sequence<ByteString>>'](V, iterator.bind(V))
}
Expand Down
5 changes: 2 additions & 3 deletions lib/web/fetch/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -459,9 +459,8 @@ class Request {
// 4. If headers is a Headers object, then for each header in its header
// list, append header’s name/header’s value to this’s headers.
if (headers instanceof HeadersList) {
for (const { 0: key, 1: val } of headers) {
// Note: The header names are already in lowercase.
headersList.append(key, val, true)
for (const [key, val] of headers) {
headersList.append(key, val)
}
// Note: Copy the `set-cookie` meta-data.
headersList.cookies = headers.cookies
Expand Down
30 changes: 0 additions & 30 deletions test/fetch/headers-case.js

This file was deleted.

0 comments on commit 8f2c2f5

Please sign in to comment.