perf: avoid setImmediate if body is reading (#3210)

nodejs · May 7, 2024 · d51dabc · d51dabc
1 parent 94c9aa9
commit d51dabc
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/api/readable.js b/lib/api/readable.js
@@ -63,9 +63,13 @@ class BodyReadable extends Readable {
     // tick as it is created, then a user who is waiting for a
     // promise (i.e micro tick) for installing a 'error' listener will
     // never get a chance and will always encounter an unhandled exception.
-    setImmediate(() => {
+    if (!this[kReading]) {
+      setImmediate(() => {
+        callback(err)
+      })
+    } else {
       callback(err)
-    })
+    }
   }
 
   on (ev, ...args) {