Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap can't run tests because node option --experimental-wasm-simd doesn't exist in v20 #2086

Closed
KhafraDev opened this issue Apr 23, 2023 · 2 comments · Fixed by #2087
Closed
Labels
bug Something isn't working

Comments

@KhafraDev
Copy link
Member

Refs: https://github.com/nodejs/undici/actions/runs/4775514329/jobs/8489868744

node-arg: --experimental-wasm-simd

It might be safe to remove the option for lower versions but I'm not sure.

@KhafraDev KhafraDev added the bug Something isn't working label Apr 23, 2023
@targos
Copy link
Member

targos commented Apr 23, 2023

The flag was removed in https://chromium-review.googlesource.com/c/v8/v8/+/3957636
They say it was enabled by default in Chrome 91. This corresponds to Node.js v16.4.0.

@KhafraDev
Copy link
Member Author

thanks, I couldn't find info on it :) thinking it over I doubt removing the flag will cause issues in v14. Ill test it tomorrow if no one else does so before me

KhafraDev added a commit to KhafraDev/undici that referenced this issue Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants