Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/website has broken benchmark links #2988

Closed
MattBidewell opened this issue Mar 23, 2024 · 0 comments
Closed

Documentation/website has broken benchmark links #2988

MattBidewell opened this issue Mar 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MattBidewell
Copy link
Contributor

MattBidewell commented Mar 23, 2024

Bug Description

On undici.nodejs.org the benchmark links on the home page are link to 404 files. The same links work in the Readme.

Good first issue

Reproducible By

Head over to https://undici.nodejs.org/#/ and click on the example hyperlink under benchmarks header.

Expected Behavior

It will link to the relevant example benchmark file.

Logs & Screenshots

Homepage:

image

Benchmark example link:
image

Environment

Documentation based.

Additional context

Changes made should work in both

@MattBidewell MattBidewell added the bug Something isn't working label Mar 23, 2024
@MattBidewell MattBidewell changed the title Documentation/website broken benchmark links Documentation/website has broken benchmark links Mar 23, 2024
ben-halverson pushed a commit to ben-halverson/undici that referenced this issue Mar 25, 2024
benhalverson pushed a commit to benhalverson/undici that referenced this issue Mar 25, 2024
benhalverson added a commit to benhalverson/undici that referenced this issue Mar 25, 2024
@ronag ronag closed this as completed in 83f36b7 Mar 25, 2024
mertcanaltin pushed a commit to mertcanaltin/undici that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant