-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly tests are failing #3017
Comments
Tests against nightly failed, see: https://github.com/nodejs/undici/actions/runs/8479709727 |
It doesn't seem an |
Agreed with @metcoder95 Are the daily Node-nightly tests causing too much issue fatigue? In 14 runs, we've had 3 issues raised:
I can think of a couple potential improvements if needed (either individually, or some combination of the following):
Thoughts? |
Oh, and naturally if we identify a recurring issue or flakiness with the nightly builds unrelated to undici, getting an issue raised with the responsible group is ideal. |
The daily runs don't seem to be a problem (yet) per se, though the flakiness is something that might be problematic. I'm ok with running it every day, but maybe we should have retries, and after X retries (let's say 3) we raise the issue to investigate. Especially if we have issues that can be fixed with a simple retry |
Tests against nightly failed, see: https://github.com/nodejs/undici/actions/runs/8489978599 |
it seems the windows build to be broken on windows somehow. Maybe we can just remove it for now? |
No description provided.
The text was updated successfully, but these errors were encountered: