Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly tests are failing #3017

Closed
github-actions bot opened this issue Mar 29, 2024 · 7 comments
Closed

Nightly tests are failing #3017

github-actions bot opened this issue Mar 29, 2024 · 7 comments

Comments

@github-actions
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Tests against nightly failed, see: https://github.com/nodejs/undici/actions/runs/8479709727

@metcoder95
Copy link
Member

It doesn't seem an undici issue

@mweberxyz
Copy link
Contributor

mweberxyz commented Mar 29, 2024

Agreed with @metcoder95

Are the daily Node-nightly tests causing too much issue fatigue?

In 14 runs, we've had 3 issues raised:

  1. This one, which appears to be an issue with the nightly build,
  2. Nightly tests are failing #3008, which was a flakey test run
  3. Nightly tests are failing #2977, which was resolved by a undici change

I can think of a couple potential improvements if needed (either individually, or some combination of the following):

  1. Automatically close issues if a subsequent daily-nightly passes
  2. Don't raise these issues until there are multiple consecutive failures
  3. Run tests more often (every 6 hours? every hour? -- in conjunction with the previous to get useful signals)
  4. Add retry logic into the nightly tests themselves -- don't count the first failure as a failure.

Thoughts?

@mweberxyz
Copy link
Contributor

mweberxyz commented Mar 29, 2024

Oh, and naturally if we identify a recurring issue or flakiness with the nightly builds unrelated to undici, getting an issue raised with the responsible group is ideal.

@metcoder95
Copy link
Member

metcoder95 commented Mar 29, 2024

The daily runs don't seem to be a problem (yet) per se, though the flakiness is something that might be problematic.

I'm ok with running it every day, but maybe we should have retries, and after X retries (let's say 3) we raise the issue to investigate. Especially if we have issues that can be fixed with a simple retry

Copy link
Contributor Author

Tests against nightly failed, see: https://github.com/nodejs/undici/actions/runs/8489978599

@mcollina
Copy link
Member

it seems the windows build to be broken on windows somehow. Maybe we can just remove it for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants