Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows/nightly.yml): create issue only on all platforms fail #3020

Merged

Conversation

mweberxyz
Copy link
Contributor

@mweberxyz mweberxyz commented Mar 30, 2024

This relates to...

Rationale

In the four nightly failures so far, 3 were not undici's fault and only one platform failed. In the one true positive error, all three platforms failed tests, therefore only create/comment issue if all three platform fail.

Sample Runs

  1. All platforms succeed: https://github.com/mweberxyz/nodejs-undici/actions/runs/8491820300
    No issue created
  2. Single platform fails: https://github.com/mweberxyz/nodejs-undici/actions/runs/8491975740
    No issue created
  3. All platforms fail: https://github.com/mweberxyz/nodejs-undici/actions/runs/8491957840
    Issue created: Nightly tests are failing mweberxyz/nodejs-undici#8

Changes

.github/workflows/nightly.yml:

  • remove matrix to give each platform a stable id
  • only run report-failureif all three platforms fail

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (9278de9) to head (396a1a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3020   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          89       89           
  Lines       24231    24231           
=======================================
  Hits        22659    22659           
  Misses       1572     1572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ad4a5e5 into nodejs:main Mar 30, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants