-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not encode with encodeURIComponent if query with method GET passed. #3287
Comments
I can do it, if it is possible. |
Can you provide an |
for example: API CALL: EXPECTED URL GENERATED: WHAT DEBUG MODE SHOWS: HOW TO RUN: as you see it is encoded, this example will work but some server rest implementation (which I would call them bad designed) they don't accept encodedURIComponent in the query string. |
If you build the whole url yourself and don't use |
Yes I know, but I would prefer to not, when the library is doing it, I was wondering if there could be an option that could be passed to not encode the url? |
Maybe we should consider to pass a queryparser as an option? |
I don't think we want to maintain special code for bad behaving servers. You will need to do this "hack" in user space. |
I have studied the source code and saw this file
lib/core/util.js
which there is a function calledbuildURL
and it is using node's querystring which by default is doingencodeURIComponent
causing a third party backend that I'm calling to be broken, as I can not ask them to change, so preferably, it would be much nicer in undici we can have a option to disableencodeURIComponent
or enable it.The text was updated successfully, but these errors were encountered: