-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pause queue while piping #52
Labels
bug
Something isn't working
Comments
I think that comment is old/incorrect. The queue has a parallelism of 1, so it won't start processing a new entry before the callback is called. |
Are you sure? Isn't the whole thing with queue concurrency (i.e. pipelining) that multiple tasks can be running concurrently? I agree it has parallelism of what, when pipelinig is set to 1. |
You are right, the problem exists. |
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 4, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 6, 2020
Merged
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 6, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 6, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 6, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 6, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
ronag
added a commit
to nxtedition/undici
that referenced
this issue
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed the following comment https://github.com/mcollina/undici/blob/master/lib/client.js#L199.
I think if we don't fix this we have a serious bug where the next request can start writing to the socket interleaved with the current request body which will basically corrupt the whole client data stream. Or am I missing something?
The text was updated successfully, but these errors were encountered: