Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark resource timing #952

Closed
ronag opened this issue Aug 13, 2021 · 8 comments · Fixed by #1517
Closed

mark resource timing #952

ronag opened this issue Aug 13, 2021 · 8 comments · Fixed by #1517
Labels
fetch question [Use a Discussion instead]

Comments

@ronag
Copy link
Member

ronag commented Aug 13, 2021

Does node have something similar to https://w3c.github.io/resource-timing/#dfn-mark-resource-timing which would make sense to report fetch info to?

undici/lib/fetch/index.js

Lines 207 to 213 in 3d2dbc7

markResourceTiming(timingInfo, originalURL, initiatorType, global, cacheState)
}
// https://w3c.github.io/resource-timing/#dfn-mark-resource-timing
function markResourceTiming () {
// TODO
}

@nodejs/diagnostics @addaleax @jasnell

@ronag ronag added bug Something isn't working fetch question [Use a Discussion instead] and removed bug Something isn't working labels Aug 13, 2021
@Qard
Copy link
Member

Qard commented Aug 14, 2021

This would connect to perf_hooks but will need some additions. We have PerformanceEntry but no PerformanceResourceTiming yet. I don't think it would be difficult to add though. 🤔

@jasnell
Copy link
Member

jasnell commented Aug 14, 2021

It's certainly doable. We'll need to expose a public API for publishing custom performance entries. Not unreasonable at all.

@RafaelGSS

This comment was marked as outdated.

@jasnell
Copy link
Member

jasnell commented Oct 1, 2021

I should be able to carve out some time next week to see what we need in node.js to make this a bit more feasible.

@RafaelGSS
Copy link
Member

FYI I'm working on that in Node.js core. Planning a PR in Node.js in the next coming days.

@RafaelGSS
Copy link
Member

FYI: PerformanceResourceTiming was just merged into master and it will be released next Tuesday on v18.2.

@RafaelGSS
Copy link
Member

@Trott I think this issue doesn't need to be closed because undici.fetch doesn't use it yet.

@Trott
Copy link
Member

Trott commented May 13, 2022

@Trott I think this issue doesn't need to be closed because undici.fetch doesn't use it yet.

I didn't manually close it. It got closed because of the "Fixes:" line in the commit message. Feel free to re-open or whatever you want to do with it. I have no opinion at all.

BethGriggs pushed a commit to nodejs/node that referenced this issue May 16, 2022
perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add PerformanceResourceTiming

perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add Resource Timing documentation

benchmark: measure resource timing module

perf_hooks: add check avoiding new PerformanceResourceTiming

perf_hooks: adjust doc

PR-URL: #42725
Fixes: nodejs/undici#952
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue May 31, 2022
perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add PerformanceResourceTiming

perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add Resource Timing documentation

benchmark: measure resource timing module

perf_hooks: add check avoiding new PerformanceResourceTiming

perf_hooks: adjust doc

PR-URL: #42725
Fixes: nodejs/undici#952
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Jul 12, 2022
perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add PerformanceResourceTiming

perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add Resource Timing documentation

benchmark: measure resource timing module

perf_hooks: add check avoiding new PerformanceResourceTiming

perf_hooks: adjust doc

PR-URL: #42725
Fixes: nodejs/undici#952
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Jul 31, 2022
perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add PerformanceResourceTiming

perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add Resource Timing documentation

benchmark: measure resource timing module

perf_hooks: add check avoiding new PerformanceResourceTiming

perf_hooks: adjust doc

PR-URL: #42725
Fixes: nodejs/undici#952
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add PerformanceResourceTiming

perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add Resource Timing documentation

benchmark: measure resource timing module

perf_hooks: add check avoiding new PerformanceResourceTiming

perf_hooks: adjust doc

PR-URL: nodejs/node#42725
Fixes: nodejs/undici#952
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetch question [Use a Discussion instead]
Projects
None yet
5 participants