-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fetch methods #958
Comments
I'd like to help! |
Though I have a question: do we need to implement those browser related features such as cors, content security policy in undici fetch? |
Some of those are indeed only browser related, you can either implement them if possible or add a note explaining why we don't need to implement them and return a appropriate value or an assertion. |
I'd like to confirm what we think about |
Browser-related features might be useful when used with https://github.com/jsdom/jsdom but I don't have any use case for this. |
We implement them because it's easy to just follow the spec literally. |
It also supports isomorphic javascript. |
Hey there is it okay if I try to implement some of them? :D |
@KhafraDev is there anything left to implement? |
No, everything is done. |
Under
lib/fetch/util.js
we have a few helper methods that are pretty well documented in spec and and needs to be implemented:The text was updated successfully, but these errors were encountered: