Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetch methods #958

Closed
8 tasks done
ronag opened this issue Aug 14, 2021 · 11 comments
Closed
8 tasks done

Implement fetch methods #958

ronag opened this issue Aug 14, 2021 · 11 comments
Labels
fetch good first issue Good for newcomers
Milestone

Comments

@ronag
Copy link
Member

ronag commented Aug 14, 2021

Under lib/fetch/util.js we have a few helper methods that are pretty well documented in spec and and needs to be implemented:

  • appendRequestOriginHeader
  • appendFetchMetadata
  • TAOCheck
  • corsCheck
  • crossOriginResourcePolicyCheck
  • makePolicyContainer
  • clonePolicyContainer
  • determineRequestsReferrer
@ronag ronag added good first issue Good for newcomers fetch labels Aug 14, 2021
@ronag
Copy link
Member Author

ronag commented Aug 14, 2021

@szmarczak

@ronag ronag mentioned this issue Aug 16, 2021
@wong2
Copy link
Contributor

wong2 commented Aug 17, 2021

I'd like to help!

@wong2
Copy link
Contributor

wong2 commented Aug 17, 2021

Though I have a question: do we need to implement those browser related features such as cors, content security policy in undici fetch?

@ronag
Copy link
Member Author

ronag commented Aug 17, 2021

Some of those are indeed only browser related, you can either implement them if possible or add a note explaining why we don't need to implement them and return a appropriate value or an assertion.

@ronag ronag mentioned this issue Aug 17, 2021
39 tasks
@wong2
Copy link
Contributor

wong2 commented Aug 20, 2021

I'd like to confirm what we think about cors related features, for example, mode is currently supported, while it's unimplemented in node-fetch. Do we want to support them as much as we can? Or are they unnecessary complexities?

@szmarczak
Copy link
Member

Browser-related features might be useful when used with https://github.com/jsdom/jsdom but I don't have any use case for this.

@ronag
Copy link
Member Author

ronag commented Aug 20, 2021

I'd like to confirm what we think about cors related features, for example, mode is currently supported, while it's unimplemented in node-fetch. Do we want to support them as much as we can? Or are they unnecessary complexities?

We implement them because it's easy to just follow the spec literally.

@btakita
Copy link

btakita commented Jan 23, 2022

It also supports isomorphic javascript.

@Viper-space
Copy link

Hey there is it okay if I try to implement some of them? :D

@ronag
Copy link
Member Author

ronag commented Oct 28, 2022

@KhafraDev is there anything left to implement?

@KhafraDev
Copy link
Member

No, everything is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetch good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants