-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch #915
Comments
Looks great! I'll take a deeper look at this when I can and try to pick something up |
In regards to documentation should we document it or just refer to the spec/MDN ofc with differences/limitations mentioned? @mcollina @szmarczak @Ethan-Arrowood |
I think we should be ok in referring to MDN and documenting the difference/limitations... at least for now. |
I landed on this issue after reading about questions on undici fetch web compliance in nodejs/node#41749 (review) I think it would be helpful if a link to web compliance summary is provided in README at https://github.com/nodejs/undici#undicifetchinput-init-promise It would be up to undici team on how they would like to track the web compliance. I would recommend creating a milestone similar to https://github.com/nodejs/undici/milestone/5 where all compliance related issues can be added to. WDYT? |
As part of naming and compliance related questions, They have documented deviations in Deno fetch implementation from web spec in their docs at https://deno.land/manual@v1.18.1/runtime/web_platform_apis#spec-deviations |
I did not ask Deno team. |
My bad, it was @benjamingr who created an issue with Deno team. I've edited my comment. |
Things to help out with to bring fetch out of experimental status.
Headers
and spec comments + fixes (Add spec comments to Header class #933)Blob.type
(Blob should have response content type #925)data:
uri (Add support for data uri's in fetch #929)httpNetworkFetch
spec compliance.FormData
(FormData #930)highWaterMark
browser compatibility (Fetch highWaterMark #923)Request.clone
Response.clone
( Fix Request.clone #945)Tests
Response
https://github.com/nodejs/undici/blob/main/lib/api/api-fetch/index.js#L158
https://github.com/nodejs/undici#parameter-response
https://fetch.spec.whatwg.org/#response-class
clone()
(fix: fetch response is not Readable #921)statusText
Response
class (fix: implement fetch per spec #928)Response
classRequest
Request
class (fix: implement fetch per spec #928)Request
classHeaders
Headers
class (fix: implement fetch per spec #928)Headers
classSpec
#958
The text was updated successfully, but these errors were encountered: