fetch: fix small spec inconsistency #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This condition is not *yet* possible to meet so I couldn't add a test (sorry!). The responseTainting is always set here or a network error is returned (.status = 0 is a network error which makes the check never pass): https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L529 and the condition is always met because response is never set https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L475 The spec says that "[a] basic filtered response is a filtered response whose type is "basic" and header list excludes any headers in internal response’s header list whose name is a forbidden response-header name." The library was incorrectly excluding valid headers. If `data:`, `blob:`, `about:`, or `file:` URIs are ever supported, this change will be needed.
|
Thanks! |
KhafraDev
added a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
This condition is not *yet* possible to meet so I couldn't add a test (sorry!). The responseTainting is always set here or a network error is returned (.status = 0 is a network error which makes the check never pass): https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L529 and the condition is always met because response is never set https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L475 The spec says that "[a] basic filtered response is a filtered response whose type is "basic" and header list excludes any headers in internal response’s header list whose name is a forbidden response-header name." The library was incorrectly excluding valid headers. If `data:`, `blob:`, `about:`, or `file:` URIs are ever supported, this change will be needed.
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
This condition is not *yet* possible to meet so I couldn't add a test (sorry!). The responseTainting is always set here or a network error is returned (.status = 0 is a network error which makes the check never pass): https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L529 and the condition is always met because response is never set https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L475 The spec says that "[a] basic filtered response is a filtered response whose type is "basic" and header list excludes any headers in internal response’s header list whose name is a forbidden response-header name." The library was incorrectly excluding valid headers. If `data:`, `blob:`, `about:`, or `file:` URIs are ever supported, this change will be needed.
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This condition is not *yet* possible to meet so I couldn't add a test (sorry!). The responseTainting is always set here or a network error is returned (.status = 0 is a network error which makes the check never pass): https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L529 and the condition is always met because response is never set https://github.com/nodejs/undici/blob/main/lib/fetch/index.js#L475 The spec says that "[a] basic filtered response is a filtered response whose type is "basic" and header list excludes any headers in internal response’s header list whose name is a forbidden response-header name." The library was incorrectly excluding valid headers. If `data:`, `blob:`, `about:`, or `file:` URIs are ever supported, this change will be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This condition is not yet possible to meet so I couldn't add a test
(sorry!).
responseis always nullundici/lib/fetch/index.js
Line 475 in 09059fb
undici/lib/fetch/index.js
Line 529 in 09059fb
responseTaintingto eitheropaqueorcors.response.status === 0would be a network error)undici/lib/fetch/index.js
Line 605 in 09059fb
The spec says that "[a] basic filtered response is a filtered response
whose type is "basic" and header list excludes any headers in internal
response’s header list whose name is a forbidden response-header name."
The library was incorrectly excluding valid headers.
If
data:,blob:,about:, orfile:URIs are ever supported, thischange will be needed.