Pass callback directly to connect, reconnect #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure that initial socket connection errors are caught. Alternatively, we could push the callback into the queue before calling `connect`. However, that has potential side-effects. I went for the solution with the least chance of unintended consequences.
|
Nevermind, there are some issues with this. That is, it does not resolve the issue save for the very first call. Will work on a better solution. |
ronag
pushed a commit
that referenced
this pull request
Jan 13, 2022
* fix: 'same origin' & setting response * fix: remove httpRedirectFetch step #12
KhafraDev
referenced
this pull request
in KhafraDev/undici
Jun 23, 2022
* fix: 'same origin' & setting response * fix: remove httpRedirectFetch step #12
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: 'same origin' & setting response * fix: remove httpRedirectFetch step nodejs#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that initial socket connection errors are caught.
Alternatively, we could push the callback into the queue before calling
connect. However, that has potential side-effects. I went for thesolution with the least chance of unintended consequences.