feat(Headers): spec-compliant fill
& constructor
#1502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
in thefill
method. Weird behavior can be entirely explained with one word: "webidl".record<key, value>
converter.webidl.sequenceConverter
andwebidl.converters.sequence
as the latter has no uses without the former.p.s. once I make a pr for
Response
/Request
idl, I am going to make a PR to improve the error messages.No major changes in this pr. All current tests pass (other than 2 which were invalid) and node-fetch tests pass.