Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional WebSocket send tests to cover all payload size categories #2149

Merged
merged 5 commits into from
Jun 7, 2023

Commits on May 2, 2023

  1. Fixed bug in 16-bit frame length when buffer is a subarray

    I was just bitten by this issue. Because buffer could be a subarray, the `byteOffset` and `byteLength` arguments to `new DataView()` are required, otherwise the length value may be written at the wrong offset.
    
    Alternatively, it looks like it would be simpler (and it also works) to replace the patched line with `buffer.writeUInt16BE(bodyLength, 2)`.
    jawj committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5be63ff View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from jawj/jawj-patch-1

    Fixed bug in 16-bit frame length when buffer is a subarray
    jawj committed May 2, 2023
    Configuration menu
    Copy the full SHA
    39146f4 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Switched 16-bit length-writing fix to use Buffer.writeUInt16 instead …

    …of DataView.setUint16, and added a test for the fix
    jawj committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c6ce7f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    b13090f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0ed727 View commit details
    Browse the repository at this point in the history