Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable conditional WPT Report for websockets #2406

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Nov 7, 2023

Reverts #2379 and re-enables #2351 while keeping windows CI happy.

@panva

This comment was marked as outdated.

@panva panva marked this pull request as draft November 7, 2023 09:22
@panva panva force-pushed the run-websockets-again branch 2 times, most recently from 32d0a23 to 8a898bd Compare November 7, 2023 09:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (16dc3b9) 78.69%.
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
- Coverage   85.54%   78.69%   -6.86%     
==========================================
  Files          76       76              
  Lines        6858     6906      +48     
==========================================
- Hits         5867     5435     -432     
- Misses        991     1471     +480     
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/api/api-stream.js 100.00% <100.00%> (ø)
lib/core/connect.js 80.00% <100.00%> (-1.25%) ⬇️
lib/fetch/body.js 97.22% <100.00%> (-0.47%) ⬇️
lib/fetch/constants.js 97.22% <100.00%> (+0.67%) ⬆️
lib/fetch/file.js 94.31% <100.00%> (-1.09%) ⬇️
lib/fetch/global.js 100.00% <ø> (ø)
lib/fetch/response.js 97.04% <100.00%> (+1.20%) ⬆️
lib/fetch/util.js 85.82% <100.00%> (ø)
lib/pool.js 100.00% <100.00%> (ø)
... and 8 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panva
Copy link
Member Author

panva commented Nov 7, 2023

Ah well, I tried.

@panva panva closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants