Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket: remove dead code in parseCloseBody #2902

Merged
merged 1 commit into from Mar 2, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Mar 2, 2024

No description provided.

@Uzlopak Uzlopak requested a review from KhafraDev March 2, 2024 06:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.83%. Comparing base (28b2df8) to head (f7437da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2902      +/-   ##
==========================================
+ Coverage   93.81%   93.83%   +0.02%     
==========================================
  Files          85       85              
  Lines       23424    23416       -8     
==========================================
- Hits        21975    21973       -2     
+ Misses       1449     1443       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit fc4e766 into nodejs:main Mar 2, 2024
16 checks passed
@Uzlopak Uzlopak deleted the remove-dead-code-receiver branch March 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants