Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increase test coverage to 100% for /lib/api/api-request.js #2912

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore: increase test coverage to 100% for /lib/api/api-request.js #2912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 17 additions & 1 deletion test/node-test/client-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ test('retry idempotent inflight', async (t) => {
})

test('invalid opts', async (t) => {
const p = tspl(t, { plan: 2 })
const p = tspl(t, { plan: 5 })

const client = new Client('http://localhost:5000')
client.request(null, (err) => {
Expand All @@ -1065,6 +1065,22 @@ test('invalid opts', async (t) => {
client.pipeline(null).on('error', (err) => {
p.ok(err instanceof errors.InvalidArgumentError)
})
client.request({
path: '/',
method: 'GET',
highWaterMark: '1000'
}, (err) => {
p.ok(err instanceof errors.InvalidArgumentError)
p.strictEqual(err.message, 'invalid highWaterMark')
})
client.request({
path: '/',
method: 'GET',
highWaterMark: -1
}, (err) => {
p.ok(err instanceof errors.InvalidArgumentError)
p.strictEqual(err.message, 'invalid highWaterMark')
})

await p.completed
})
Expand Down