feat: onConnect w/ controller #3028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 93.56% 93.55% -0.02%
==========================================
Files 89 89
Lines 24301 24424 +123
==========================================
+ Hits 22737 22849 +112
- Misses 1564 1575 +11 ☔ View full report in Codecov by Sentry. |
mcollina
requested changes
Mar 31, 2024
ronag
force-pushed
the
on-start
branch
2 times, most recently
from
1c3cdbf
to
61cfc20
Compare
Part of a larger overhauld of hooks. This on is not breaking and can therefore land earlier.
metcoder95
approved these changes
Apr 3, 2024
ronag
force-pushed
the
on-start
branch
6 times, most recently
from
91b0f26
to
3d331a2
Compare
|
Updated according to feedback from @BridgeAR |
ronag
force-pushed
the
on-start
branch
12 times, most recently
from
dc978ac
to
41dc118
Compare
ronag
force-pushed
the
on-start
branch
6 times, most recently
from
ab0766f
to
714d50f
Compare
|
Closing in favour of #3051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a larger overhauld of hooks. This on is not breaking and can therefore land earlier.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status