fix: unify Pool and Client APIs #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronag
commented
Feb 10, 2021
ronag
commented
- 'connect' and 'disconnect' event should have same arguments.
- connected should be an integer
ronag
added
the
semver-major
|
This allows e.g. using |
|
test added |
ronag
force-pushed
the
unify-pool-client
branch
from
acb266d
to
03c743a
Compare
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 16 16
Lines 1386 1387 +1
=======================================
+ Hits 1380 1381 +1
Misses 6 6
Continue to review full report at Codecov.
|
Merged
|
I'm going to update my docs PR to include these changes now too |
Merged
Ethan-Arrowood
added a commit
to Ethan-Arrowood/undici
that referenced
this pull request
Feb 18, 2021
ronag
pushed a commit
that referenced
this pull request
Feb 21, 2021
* start new docs pages following style guide * scaffold Client and start filling in * slight tweaks * add alt overload syntax * add destroy and dispatch * rename interface to parameter * more style guide and add request method * complete client section * move style-guide to mddl * Complete Client.dispatch * add example to constructor * complete client.close * Complete client.connect * finish destroy method * add request docs * add examples to request * complete stream method * complete upgrade and pipeline sections * remove some files * try alt callback overload style * remove redundant async * remove fastify dep and add catch to upgrade example * change callback/promise style * complete incomplete example * remove redundant callback description * improve event sections * complete events examples * improve stream example * change stream example, reorder dispatch sections * fix #544 changes * complete Dispatch Upgrade request example * review pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.