fix: wait for queued handlers to run before onError #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When e.g. returning a stream through resolve the user needs to get a chance to register an 'error' handler before the stream is destroyed. Otherwise we risk an unhandled exception.
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 99.56% 99.57%
=======================================
Files 16 16
Lines 1386 1408 +22
=======================================
+ Hits 1380 1402 +22
Misses 6 6
Continue to review full report at Codecov.
|
ronag
commented
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When e.g. returning a stream through resolve the user
needs to get a chance to register an 'error' handler
before the stream is destroyed. Otherwise we risk an
unhandled exception.