fix: omit 'path' in undici.request opts (ts) #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In undici.request|stream|pipeline helper functions, the opts param may not contain path. see https://github.com/nodejs/undici#undicirequesturl-opts-promise
|
Unfortunately the types are quite out of date from the v3 API. I'm okay with this change though to bring it closer - I'm fairly confident not a lot of folks are using undici in TS projects just yet |
mcollina
requested changes
Feb 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 16 16
Lines 1398 1398
=======================================
Hits 1392 1392
Misses 6 6 Continue to review full report at Codecov.
|
|
@mcollina type tests updated |
mcollina
approved these changes
Feb 21, 2021
Ethan-Arrowood
approved these changes
Feb 23, 2021
|
Hello! I've just run in to this issue in our TS project :) I can see this code has been merged but not deployed yet, do you have a planned release date at all for this fix? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
undici.request|stream|pipelinehelper functions, the opts param may not contain path.see https://github.com/nodejs/undici#undicirequesturl-opts-promise
Without this fix you get the following Typescript error:
But if you pass the path parameter you get a runtime error: https://github.com/nodejs/undici/blob/master/lib/agent.js#L86-L88