Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the esm wrapper, rely on commonjs autodetection #599

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Remove the esm wrapper, rely on commonjs autodetection #599

merged 2 commits into from
Mar 17, 2021

Conversation

mcollina
Copy link
Member

Fixes #598

@mcollina mcollina requested a review from dnlup March 15, 2021 19:20
Ethan-Arrowood
Ethan-Arrowood approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dnlup
dnlup approved these changes Mar 16, 2021
View reviewed changes
index.js Show resolved Hide resolved
package.json Show resolved Hide resolved
@mcollina
Copy link
Member Author

rebased. Lmk if you are still good to land

@codecov-io
Copy link

codecov-io commented Mar 16, 2021 •
edited

Codecov Report

Merging #599 (ff6453c) into main (60c1ea0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          16       16           
  Lines        1444     1444           
=======================================
  Hits         1432     1432           
  Misses         12       12
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c1ea0...ff6453c. Read the comment docs.

dnlup
dnlup approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@dnlup dnlup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Should we squash the commits?

@mcollina
Copy link
Member Author

I'll squash on landing.

@mcollina mcollina merged commit 2366fa3 into main Mar 17, 2021
@mcollina mcollina deleted the support-named-exports branch March 17, 2021 13:37
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@mcollina @crysmags
Remove the esm wrapper, rely on commonjs autodetection (nodejs#599)
7da9fb6 
* Remove the esm wrapper, rely on commonjs autodetection

Fixes nodejs#598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@dnlup dnlup dnlup approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Agent in esm exports
5 participants
@mcollina @codecov-io @ronag @dnlup @Ethan-Arrowood