Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pr and issue templates #608

Merged
merged 4 commits into from
Mar 23, 2021
Merged

chore: add pr and issue templates #608

merged 4 commits into from
Mar 23, 2021

Conversation

Nytelife26
Copy link
Contributor

@Nytelife26 Nytelife26 commented Mar 23, 2021

This relates to...

Objectives 1 and 2 of #584 (I also checked Objective 6, so that may be crossed
off too).

Rationale

N/A (justified by above).

Changes

  • Added bug report issue template
  • Added feature request issue template
  • Added general PR template (the one used to make this PR)

Features

N/A.

Bug Fixes

N/A.

Breaking Changes and Deprecations

N/A.

Status

  • [S] Tested
  • [S] Benchmarked (optional)
  • Documented
  • Review ready
  • In review
  • Merge ready

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! for this, I've added a few notes

.github/PULL_REQUEST_TEMPLATE/template.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE/template.md Show resolved Hide resolved
@Nytelife26
Copy link
Contributor Author

Thanks! for this, I've added a few notes

All requested changes implemented, ready for re-review :)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
Copy link
Member

ronag commented Mar 23, 2021

Thanks!

@ronag ronag merged commit c9a56af into nodejs:main Mar 23, 2021
@Ethan-Arrowood
Copy link
Collaborator

Opened and merged before I could even review and it looks great 😄 thanks for adding these!

@Nytelife26
Copy link
Contributor Author

Thanks!

Opened and merged before I could even review and it looks great smile thanks for adding these!

Happy to help :)

crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* chore: add issue templates

* chore: add pr template

* chore: reduce ambiguity of pr template

* chore(pr-template): implement guidelines and origin certificate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants