fix: add connect timeout

[ronag]

Haven't been able to build a test case for this but in production I have case where neither 'connect' not 'error' is invoked on a socket after socket.connect().

[codecov-io]

Codecov Report

Merging #619 (1381b5e) into main (56bd998) will increase coverage by 0.60%.
The diff coverage is 61.11%.

❗ Current head 1381b5e differs from pull request most recent head 5b3d2f4. Consider uploading reports for the commit 5b3d2f4 to get more accurate results

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   98.03%   98.63%   +0.60%     
==========================================
  Files          17       17              
  Lines        1574     1463     -111     
==========================================
- Hits         1543     1443     -100     
+ Misses         31       20      -11     

Impacted Files	Coverage Δ
lib/core/errors.js	92.75% <0.00%> (-7.25%)	⬇️
lib/core/symbols.js	100.00% <ø> (ø)
lib/core/client.js	98.82% <84.61%> (+0.04%)	⬆️
lib/llhttp/parser.js
lib/node/http-parser.js	100.00% <0.00%> (ø)
lib/core/util.js	96.05% <0.00%> (+7.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bd998...5b3d2f4. Read the comment docs.

[mcollina]

I would really prefer if this had a test.

Does it worsen our benchmarks?

[mcollina]

Should this have a default as it can happen in reality?

[ronag]

Should this have a default as it can happen in reality?

It has a default. 10s.

[ronag]

Should this have a default as it can happen in reality?

Any idea on how to reproduce this scenario? When I try I always get an error. Maybe if I monkeypatch the global socket prototype :/?

[ronag]

Does it worsen our benchmarks?

No.

[dnlup]

Should this have a default as it can happen in reality?

Any idea on how to reproduce this scenario? When I try I always get an error. Maybe if I monkeypatch the global socket prototype :/?

Can we tap into some net.Server hook and delay the connect event?

Nvm, I don't see anything public we can use server-side to delay the connect event client side, I don't know what I was thinking.

[mcollina]

Any idea on how to reproduce this scenario? When I try I always get an error. Maybe if I monkeypatch the global socket prototype :/?

Go for it in its own test file.

[ronag]

Added test