fix: add more strict check for streams in `util.isStream()' #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 98.02% 97.96% -0.07%
==========================================
Files 17 17
Lines 1572 1574 +2
==========================================
+ Hits 1541 1542 +1
- Misses 31 32 +1
Continue to review full report at Codecov.
|
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: add more strict check for streams in `util.isStream()' * fix: split `isReadable()` & `isWritable()` for more specific checks * fix: delete was not working to remove `destroy()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #625 - Added a similar check that the Node.js project uses.
The check used in
undiciwas the reverse of the problem in the Node.js project. The commit mentioned in #625 shows they were missing the check for.on()whereundiciwas missing the checks forpipe()or `write()'.In its current state the
util.isStream()allowsStream, correctly returns false onBuffer, but does allowEventEmittersince it also has.on().I changed the
util.isStream()method to match what the Node.js project uses.In https://github.com/nodejs/undici/blob/main/lib/core/request.js#L39 I switched to using the newly exposed
util.isReadable()since the error message there indicates that it should be a Readable stream. There are likely other places that should use the more specificutil.isReadable().I had to change the test
stream body without destroyintest/stream-compat.jsthat was passing anEventEmitteras the requestbodysince that case now fails differently than the test was looking for. I believe I kept the spirit of the test intact.Hopefully, this is the direction intended for the issue.