Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move wasm script in build dir #642

Merged
merged 1 commit into from
Mar 30, 2021
Merged

build: move wasm script in build dir #642

merged 1 commit into from
Mar 30, 2021

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 30, 2021

Move Dockerfile and build_wasm.js inside a build folder.

Fixes #637

@ronag ronag requested a review from mcollina March 30, 2021 08:08
mcollina
mcollina approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit ed5b159 into main Mar 30, 2021
@dnlup dnlup deleted the cleanup_root branch March 30, 2021 09:12
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@dnlup @crysmags
build: move wasm script in build dir (nodejs#642)
c45ca17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup root
3 participants
@dnlup @mcollina @ronag