parser improvements #680
parser improvements #680
Conversation
Codecov Report
@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 97.25% 97.50% +0.24%
==========================================
Files 26 26
Lines 2004 2122 +118
==========================================
+ Hits 1949 2069 +120
+ Misses 55 53 -2
Continue to review full report at Codecov.
|
| if (ret !== 0) { | ||
| return ret | ||
| } | ||
| currentParser[kStatusMessage] = cstr(at, length) | ||
| return 0 |
There was a problem hiding this comment.
if this function is empty, is it still needed?
There was a problem hiding this comment.
Yes, otherwise the WASM fails
There was a problem hiding this comment.
@dnlup we might want to make this optional there, it will save a few cycle.
There was a problem hiding this comment.
Yes, all the functions exported in https://github.com/nodejs/undici/blob/main/deps/llhttp/src/api.c#L29 must be provided in the initialization.
| if (ret !== 0) { | ||
| return ret | ||
| } | ||
| currentParser[kStatusMessage] = cstr(at, length) | ||
| return 0 |
There was a problem hiding this comment.
Yes, all the functions exported in https://github.com/nodejs/undici/blob/main/deps/llhttp/src/api.c#L29 must be provided in the initialization.
lib/client.js
Outdated
| @@ -816,7 +798,11 @@ function onSocketError (err) { | |||
| } | |||
|
|
|||
| function onSocketData (data) { | |||
| this[kParser].execute(data) | |||
| try { | |||
There was a problem hiding this comment.
I see a small drop in the benchmarks, I'll run them again to be sure the use of the try/catch is having an impact.
https://github.com/nodejs/undici/runs/2275815074?check_suite_focus=true
There was a problem hiding this comment.
Removing the try catch should be easy. I’ll fix it.
There was a problem hiding this comment.
On a second run, benchmarks look good. I would not change it yet.
Benchmarks look good |
* refactor: parser upgrade * refactor: parser onBody * refactor: parser onmessagecomplete * perf: parser pre-allocate array * refactor: parser onHeaders * refactor: parser simplify * fix: remove unused var * fix: add assertion * refactor: inline makeError * refactor: parse this[kBufferSize] * refactor: parser don't are about statusMessage * fixup! fix: add assertion * fix * fix: parser kHeaders * fixup * fixup * fixuP * fixuP * fixuP * fixuP * fixuP * fixuP * fixuP * fixuP * fixuP * fixup: assertion * fixup * fixup * fixup * fixup * fixup: avoid try/catch
Refactors and simplifies parser.